Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Fix a few compiler errors in tests#97

Merged
max-schaefer merged 6 commits intogithub:rc/1.24from
max-schaefer:fix-frontend-errors
Apr 14, 2020
Merged

Fix a few compiler errors in tests#97
max-schaefer merged 6 commits intogithub:rc/1.24from
max-schaefer:fix-frontend-errors

Conversation

@max-schaefer
Copy link
Copy Markdown
Contributor

This fixes all (unintentional) errors not covered by #96.

@max-schaefer max-schaefer added this to the 1.24 milestone Apr 14, 2020
@max-schaefer max-schaefer requested a review from sauyon April 14, 2020 10:14
x = deadStore() // BAD
fallthrough
case b:
_ = x
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have caused the result above on line 385 to disappear.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, well spotted. Let me try fixing this some other way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-schaefer max-schaefer merged commit 8341ce0 into github:rc/1.24 Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants